feat: support input number component #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChatGPT Code Review:
|
4 tasks
|
这里 +/- 号的样式 disable 样式有点不统一，+ 点到底左下边框都没了，-点到底只有左边框没了 @Ricbet |
Ricbet
force-pushed
the
feat/support-input-number-component
branch
from
faac3f4
to
dd25b1a
Compare
Ricbet
force-pushed
the
feat/support-input-number-component
branch
from
5c1bec6
to
c191850
Compare
|
@Ricbet CI 处理一下 |
Ricbet
force-pushed
the
feat/support-input-number-component
branch
from
c191850
to
665368d
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 1330 1330
Lines 83676 83676
Branches 17396 17396
=======================================
+ Hits 48326 48329 +3
+ Misses 32128 32126 -2
+ Partials 3222 3221 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at faac3f4
InputNumbercomponent to thecomponentspackage (link, link, link)rc-input-numberdependency, which is added to thepackage.jsonfile (link)base.lessfile to hide the default up and down buttons for the number input in different browsers (link, link)基于 rc-input-number 实现
dark 主题
light 主题
Changelog
🤖 Generated by Copilot at faac3f4
This pull request adds a new
InputNumbercomponent to thecomponentspackage, which allows users to input numbers with up and down buttons. The component uses therc-input-numberdependency and customizes its styles and props. The component also updates the global styles for the number input and exports it from theinputfolder.