Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menuActionList component support style css properties #2711

Merged
merged 1 commit into from
May 16, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented May 16, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 3793ede

  • Add style prop to Actions component interface and pass it to Menu component (link, link)

Changelog

🤖 Generated by Copilot at 3793ede

Added a new feature to the Actions component that allows users to customize the menu style. Modified packages/core-browser/src/components/actions/index.tsx to accept a style prop and pass it to the underlying Menu component.

@opensumi
Copy link
Contributor

opensumi bot commented May 16, 2023

ChatGPT Code Review:

  1. 没有发现代码错误和拼写错误,建议保持原样。
  2. 代码增加了一个可选属性style,用于支持为组件添加 CSS 样式属性。此组件是一个菜单交互列表,当用户在菜单区域点击项目时,将触发回调函数afterClick

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ba5213f) 57.73% compared to head (3793ede) 57.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
- Coverage   57.73%   57.72%   -0.01%     
==========================================
  Files        1327     1327              
  Lines       83563    83563              
  Branches    17381    17381              
==========================================
- Hits        48242    48238       -4     
- Misses      32100    32104       +4     
  Partials     3221     3221              
Flag Coverage Δ
jsdom 52.72% <ø> (-0.01%) ⬇️
node 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit b085e3f into main May 16, 2023
15 checks passed
@Ricbet Ricbet deleted the feat/menu-action-list-support-style branch May 16, 2023 10:02
@Ricbet Ricbet self-assigned this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants