-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only add default color once #2753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
=======================================
Coverage 57.72% 57.72%
=======================================
Files 1327 1327
Lines 83581 83587 +6
Branches 17378 17381 +3
=======================================
+ Hits 48246 48253 +7
+ Misses 32114 32113 -1
Partials 3221 3221
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Ricbet
reviewed
May 30, 2023
ChatGPT Code Review:
|
erha19
reviewed
May 31, 2023
pipiiiiii
force-pushed
the
fix/theme-setting
branch
from
May 31, 2023 02:11
a80ab9e
to
573f762
Compare
Ricbet
previously approved these changes
May 31, 2023
pipiiiiii
force-pushed
the
fix/theme-setting
branch
from
May 31, 2023 02:13
573f762
to
41492b7
Compare
Ricbet
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at 588e562
fillDefaults
function (link)Issue: #2686
每次初始化 theme 时,会修改
themeSetting
引用,导致 https://github.com/opensumi/core/blob/main/packages/theme/src/browser/theme-data.ts#L576这里
index
会不一致,每次颜色会错位一个有因为
scope
会被补充为['']
,所以初始化的判断逻辑改一下就可以了Changelog
🤖 Generated by Copilot at 588e562
Fixed a bug in the workbench theme service that affected the monaco editor. Improved the default theme settings with a scope property.