Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve section label and badge style #2758

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented May 29, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at d9b8270

  • Remove unnecessary or redundant font-size and text-transform properties from accordion header and content classes (link, link, link) in styles.module.less

fixed #2491

after:

image

Changelog

🤖 Generated by Copilot at d9b8270

This pull request refactors the CSS styles of the accordion component to enhance its readability and design. It removes some unnecessary or conflicting properties from packages/main-layout/src/browser/accordion/styles.module.less.

@erha19 erha19 requested review from Ricbet and AhkunTa May 29, 2023 07:33
@opensumi opensumi bot added 🐞 bug Something isn't working 💄 style change labels May 29, 2023
@opensumi
Copy link
Contributor

opensumi bot commented May 29, 2023

ChatGPT Code Review:

  1. 代码中存在一处错误:在 .section_label 中有两处 text-transform 的属性赋值,因为第一个被注释掉了,所以可以删除掉。
  2. 代码针对网页中的一种样式进行了修改,具体来说是去掉了一个 .section_label 中的属性 text-transform: uppercase,同时也删除了 .section_badge 中的 text-transform 属性。该修改似乎是为了改进样式,并且修正了一个编号为 feat: support show unsaved files in opened editor view #2491 的问题。

@opensumi opensumi bot added the ⚙️ refactor Refactor code label May 29, 2023
Copy link
Member

@AhkunTa AhkunTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (782644f) 57.72% compared to head (d9b8270) 57.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2758   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files        1327     1327           
  Lines       83582    83582           
  Branches    17379    17379           
=======================================
  Hits        48246    48246           
  Misses      32115    32115           
  Partials     3221     3221           
Flag Coverage Δ
jsdom 52.72% <ø> (ø)
node 16.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 4b65fc4 into main May 29, 2023
15 checks passed
@erha19 erha19 deleted the style/section-title-style branch May 29, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ⚙️ refactor Refactor code 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants