Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arrow for zonewidget #2763

Merged
merged 9 commits into from
Jun 2, 2023
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented May 30, 2023

Types

  • 🎉 New Features

Background or solution

image

Changelog

🤖 Generated by Copilot at 0e93eae

This pull request adds a visual enhancement to the comments feature by introducing arrows that point to the comment threads in the editor. It also allows the customization of the arrow color and the resizing of the comment thread. The changes affect the CommentsZoneWidget, ZoneWidget, and comments-thread.ts files.

@opensumi opensumi bot added the 🎨 feature feature required label May 30, 2023
@Aaaaash
Copy link
Member Author

Aaaaash commented May 30, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 30, 2023

ChatGPT Code Review:

  1. 修改项目路径中的错误拼写,应该是 core,而不是 core-browser
  2. 此次更新主要是为了在评论功能中添加指向注释的箭头,并且允许用户自定义箭头颜色和评论线程的大小。影响到了 CommentsZoneWidget, ZoneWidget, comments-thread.ts 等文件。其中 comments-thread.ts 文件中改了一个函数的调用,CommentsZoneWidget 文件中增加了对参数 arrowColor 的处理,ZoneWidget 文件中新增了箭头的实现类 Arrow,也在 ZoneWidget 中添加了对箭头类的使用。comment.service.test.ts 文件和 comments.service.ts 文件中没有改动,只是在导入 EmitterEmitable 时改用了 @opensumi/ide-core-browser 中定义的类并做了相应的调整。

@opensumi
Copy link
Contributor

opensumi bot commented May 30, 2023

🎉 PR Next version 2.24.6-next-1685437626.0 publish successful! You can install this version via npm install package@2.24.6-next-1685437626.0

2.24.6-next-1685437626.0

@Aaaaash
Copy link
Member Author

Aaaaash commented May 30, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 30, 2023

🎉 PR Next version 2.24.6-next-1685440561.0 publish successful! You can install this version via npm install package@2.24.6-next-1685440561.0

2.24.6-next-1685440561.0

@Aaaaash
Copy link
Member Author

Aaaaash commented May 30, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 30, 2023

🎉 PR Next version 2.24.6-next-1685441841.0 publish successful! You can install this version via npm install package@2.24.6-next-1685441841.0

2.24.6-next-1685441841.0

@Aaaaash
Copy link
Member Author

Aaaaash commented May 31, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 31, 2023

🎉 PR Next version 2.24.6-next-1685498526.0 publish successful! You can install this version via npm install package@2.24.6-next-1685498526.0

2.24.6-next-1685498526.0

@Aaaaash
Copy link
Member Author

Aaaaash commented May 31, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 31, 2023

🎉 PR Next version 2.24.6-next-1685525257.0 publish successful! You can install this version via npm install package@2.24.6-next-1685525257.0

2.24.6-next-1685525257.0

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 79.68% and project coverage change: +0.02 🎉

Comparison is base (20e3b5b) 57.72% compared to head (1af9dda) 57.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
+ Coverage   57.72%   57.75%   +0.02%     
==========================================
  Files        1327     1327              
  Lines       83582    83637      +55     
  Branches    17379    17390      +11     
==========================================
+ Hits        48246    48301      +55     
  Misses      32115    32115              
  Partials     3221     3221              
Flag Coverage Δ
jsdom 52.75% <79.68%> (+0.03%) ⬆️
node 16.78% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/comments/src/browser/comments.service.ts 51.11% <0.00%> (-0.39%) ⬇️
packages/monaco-enhance/src/browser/zone-widget.ts 55.55% <83.33%> (+8.98%) ⬆️
packages/comments/src/browser/comments-thread.ts 76.04% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aaaaash Aaaaash merged commit b3e4bbb into main Jun 2, 2023
12 checks passed
@Aaaaash Aaaaash deleted the feat/add-arrow-for-zone-widget branch June 2, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants