Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize file tree node decoration, support codicon #2768

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Jun 1, 2023

Types

  • πŸŽ‰ New Features

Background or solution

fileTreeNode ηš„ decoration ζ”―ζŒ codicon

image

πŸ€– Generated by Copilot at 0b4f179

  • Add CSS styles to the file tree node element to improve its layout and appearance (link)
  • Import and use the transformLabelWithCodicon function to render codicons in the file tree node status badges (link, link)
  • Add and pass the iconService prop to the FileTreeNode component to use its fromString method to render codicons (link, link, link, link, link)

Changelog

πŸ€– Generated by Copilot at 0b4f179

This pull request adds codicon support to the file tree nodes in the file-tree-next package. It uses the IIconService and a utility function from the @opensumi/ide-theme package to render the status badges with codicons. It also improves the CSS styles of the file tree node element.

@Aaaaash Aaaaash force-pushed the feat/optimize-file-tree-node branch from 0b4f179 to 68a0876 Compare June 1, 2023 03:25
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 πŸŽ‰

Comparison is base (7791d88) 57.71% compared to head (68a0876) 57.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2768      +/-   ##
==========================================
+ Coverage   57.71%   57.73%   +0.01%     
==========================================
  Files        1327     1327              
  Lines       83587    83587              
  Branches    17381    17381              
==========================================
+ Hits        48246    48255       +9     
+ Misses      32119    32111       -8     
+ Partials     3222     3221       -1     
Flag Coverage Ξ”
jsdom 52.73% <ΓΈ> (+0.01%) ⬆️
node 16.79% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain changed the title optimize file tree node decoration, support codicon feat: optimize file tree node decoration, support codicon Jun 1, 2023
@opensumi opensumi bot added the 🎨 feature feature required label Jun 1, 2023
@Aaaaash
Copy link
Member Author

Aaaaash commented Jun 1, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 1, 2023

πŸŽ‰ PR Next version 2.24.6-next-1685606139.0 publish successful! You can install this version via npm install package@2.24.6-next-1685606139.0

2.24.6-next-1685606139.0

@erha19 erha19 merged commit 02d31e1 into main Jun 1, 2023
14 checks passed
@erha19 erha19 deleted the feat/optimize-file-tree-node branch June 1, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants