chore: optimize menuaction list renderer #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaaaash
force-pushed
the
chore/optimize-context-menu-renderer
branch
from
b097c57
to
081161b
Compare
|
/next |
|
🎉 PR Next version 2.24.6-next-1686019879.0 publish successful! You can install this version via |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
==========================================
- Coverage 57.75% 57.75% -0.01%
==========================================
Files 1330 1330
Lines 83682 83682
Branches 17396 17396
==========================================
- Hits 48333 48330 -3
- Misses 32128 32131 +3
Partials 3221 3221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
before
after
原有的 menulist 的渲染逻辑中，是将所有 menunodes 包括分割线循环渲染出来，而对于没有子菜单项的则会渲染为空，但实际上由于原本菜单项间插入的分割线，导致这种情况下，即使菜单没有被渲染，但菜单的分割线也会被渲染出来，出现连续的两条分割线
优化方式是跳过每次循环对分割线的处理，而是在渲染菜单项时判断下一个菜单项是否为分割线，与菜单项一起渲染
🤖 Generated by Copilot at b097c57
MenuActionGroupcomponent to improve readability and consistency (link)Changelog
🤖 Generated by Copilot at b097c57
This pull request enhances the appearance and usability of the menu actions component in the core-browser package. It adjusts the logic for adding dividers between menu items and submenus based on the
MenuActionGroupdata source.