Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migration static-resource to core-browser #2776

Merged
merged 6 commits into from
Jun 6, 2023

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Jun 6, 2023

Types

  • 🪚 Refactors

Background or solution

🤖 Generated by Copilot at f0ea2f3

Changelog

🤖 Generated by Copilot at f0ea2f3

This pull request moves the static resource modules from the static-resource package to the core-browser package, and updates the import statements and dependencies of other packages accordingly. This is done to simplify the dependency structure, improve the performance of the extension API, and consolidate the static resource functionality in the core browser application. The pull request also adds a new test file and a new client app contribution for the static resource service.

@opensumi opensumi bot added the ⚙️ refactor Refactor code label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 86.44% and project coverage change: -0.08 ⚠️

Comparison is base (a7d5605) 57.75% compared to head (22a56e3) 57.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
- Coverage   57.75%   57.68%   -0.08%     
==========================================
  Files        1330     1336       +6     
  Lines       83682    83857     +175     
  Branches    17396    17431      +35     
==========================================
+ Hits        48333    48375      +42     
- Misses      32128    32251     +123     
- Partials     3221     3231      +10     
Flag Coverage Δ
jsdom 52.70% <86.44%> (-0.06%) ⬇️
node 16.79% <33.89%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/static-resource/src/browser/static.definition.ts 0.00% <0.00%> (-100.00%) ⬇️
...ages/static-resource/src/browser/static.service.ts 0.00% <0.00%> (-84.22%) ⬇️
packages/static-resource/src/browser/index.ts 62.50% <57.14%> (-37.50%) ⬇️
...core-browser/src/static-resource/static.service.ts 84.21% <84.21%> (ø)
...ages/core-browser/src/bootstrap/inner-providers.ts 100.00% <100.00%> (ø)
packages/core-browser/src/index.ts 100.00% <100.00%> (ø)
packages/core-browser/src/static-resource/index.ts 100.00% <100.00%> (ø)
...e-browser/src/static-resource/static.definition.ts 100.00% <100.00%> (ø)
...es/extension/src/browser/extension-view.service.ts 47.82% <100.00%> (ø)
packages/extension/src/browser/extension.ts 55.45% <100.00%> (ø)
... and 8 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

bytemain
bytemain previously approved these changes Jun 6, 2023
@Aaaaash
Copy link
Member Author

Aaaaash commented Jun 6, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 6, 2023

🎉 PR Next version 2.24.6-next-1686038712.0 publish successful! You can install this version via npm install package@2.24.6-next-1686038712.0

2.24.6-next-1686038712.0

@bytemain bytemain merged commit 9f87a8a into main Jun 6, 2023
12 checks passed
@bytemain bytemain deleted the refactor/migration-static-resource branch June 6, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants