Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve terminal split view border style #2783

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 7, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at bb67b16

  • Changed the background color of the terminal resize handle to match the terminal border color (link)
  • Removed an empty change from terminal.color.ts (link)

close #2782

Changelog

🤖 Generated by Copilot at bb67b16

Improved the visibility and appearance of the terminal resize handle by changing its background color to match the terminal border color. Removed an empty change to packages/terminal-next/src/browser/terminal.color.ts.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a2edd8) 57.68% compared to head (bb67b16) 57.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   57.68%   57.69%           
=======================================
  Files        1336     1336           
  Lines       83865    83865           
  Branches    17432    17432           
=======================================
+ Hits        48381    48382    +1     
+ Misses      32253    32252    -1     
  Partials     3231     3231           
Flag Coverage Δ
jsdom 52.71% <ø> (+<0.01%) ⬆️
node 16.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/terminal-next/src/browser/terminal.color.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 52d2d20 into main Jun 7, 2023
14 of 15 checks passed
@erha19 erha19 deleted the style/improve-terminal-split-border branch June 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 终端分割线样式与主题不匹配
2 participants