Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: stop flexbox removing trailing whitespace on menu action #2784

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 7, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at 25a2ced

  • Preserve trailing whitespace in action buttons to avoid flexbox layout issues (link)
  • Add a comment with a link to a blog post explaining the CSS rule (link)

close #2781

Changelog

🤖 Generated by Copilot at 25a2ced

Preserve trailing whitespace in action buttons with CSS. This improves the layout and readability of the buttons in the core-browser package.

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a2edd8) 57.68% compared to head (25a2ced) 57.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2784   +/-   ##
=======================================
  Coverage   57.68%   57.68%           
=======================================
  Files        1336     1336           
  Lines       83865    83865           
  Branches    17432    17432           
=======================================
  Hits        48381    48381           
  Misses      32253    32253           
  Partials     3231     3231           
Flag Coverage Δ
jsdom 52.70% <ø> (ø)
node 16.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 7400391 into main Jun 7, 2023
14 of 15 checks passed
@erha19 erha19 deleted the fix/menubar-text branch June 7, 2023 09:17
@erha19 erha19 mentioned this pull request Jun 19, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 英文模式下,顶部 Menu 菜单异常,缺少空格
2 participants