Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix warnings and remove some useless code #2795

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 9, 2023

Types

  • 🧹 Chores

Background or solution

🤖 Generated by Copilot at ada6a20

  • Remove unused imports and parameters from RecycleList.tsx and RecycleTree.tsx (link, link, link, link)
  • Memoize setSize function in RecycleTree class with useMemo to improve performance and avoid unnecessary re-renders (link)
  • Delete commented out code that could cause performance issues in RecycleTree.tsx (link)
  • Add index to key prop of Extension component to prevent key conflicts in vsx-extension.view.tsx (link, link)
  • Add explicit type annotation for e parameter of map callback in vsx-extension.view.tsx to improve type safety and readability (link, link)

Changelog

🤖 Generated by Copilot at ada6a20

This pull request enhances the performance and readability of some components in the components and extension-manager packages. It removes unused or redundant code, memoizes a function, and fixes a prop issue.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4033de3) 57.69% compared to head (ada6a20) 57.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   57.69%   57.68%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       83866    83866              
  Branches    17432    17432              
==========================================
- Hits        48388    48380       -8     
- Misses      32248    32254       +6     
- Partials     3230     3232       +2     
Flag Coverage Δ
jsdom 52.70% <ø> (-0.01%) ⬇️
node 16.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/src/recycle-tree/TreeNodeRendererWrap.ts 28.57% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain merged commit 3d7d995 into main Jun 15, 2023
15 checks passed
@bytemain bytemain deleted the chore/fix-warnings-and-remove-some-useless-code branch June 15, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants