Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bottom panel support accordion #2798

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Jun 12, 2023

Types

  • 🎉 New Features

Background or solution

仅仅是简单对底部面板渲染层增加了 accordion 视图,以支持注册 webviewview 到底部的需求

🤖 Generated by Copilot at 6aeed2b

  • Refactor panel view component to use generic containerRef, configContext, and CustomComponent prop (link)
  • Add accordion container component to render multiple collapsible views in the panel (link)
  • Add minSize prop to accordion container to control view height (link)

Changelog

🤖 Generated by Copilot at 6aeed2b

This pull request enhances the panel view component with an accordion container and custom rendering options. It also cleans up some code in panel.view.tsx and related files.

@opensumi opensumi bot added the 🎨 feature feature required label Jun 12, 2023
@Aaaaash
Copy link
Member Author

Aaaaash commented Jun 12, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 12, 2023

🎉 PR Next version 2.25.1-next-1686563932.0 publish successful! You can install this version via npm install package@2.25.1-next-1686563932.0

2.25.1-next-1686563932.0

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (4033de3) 57.69% compared to head (6aeed2b) 57.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2798      +/-   ##
==========================================
- Coverage   57.69%   57.68%   -0.02%     
==========================================
  Files        1336     1336              
  Lines       83866    83866              
  Branches    17432    17432              
==========================================
- Hits        48388    48376      -12     
- Misses      32248    32258      +10     
- Partials     3230     3232       +2     
Flag Coverage Δ
jsdom 52.70% <ø> (-0.02%) ⬇️
node 16.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 34fd965 into main Jun 13, 2023
16 checks passed
@erha19 erha19 deleted the feat/bottom-panel-support-accordion branch June 13, 2023 02:29
Ricbet pushed a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants