Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add key for MenuActionList #2809

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: add key for MenuActionList #2809

merged 1 commit into from
Jun 15, 2023

Conversation

winjo
Copy link
Contributor

@winjo winjo commented Jun 15, 2023

Types

  • 🐛 Bug Fixes

Background or solution

Optimize MenuActionList recursiveRender to avoid error of react list key

🤖 Generated by Copilot at 0467eec

  • Fix a bug where two consecutive separators would be rendered in the menu (link)
  • Simplify the code by removing unnecessary fragments and the hasSeparator logic (link)
  • Remove the redundant key prop from the Menu.SubMenu component (link)

Changelog

🤖 Generated by Copilot at 0467eec

Fix menu rendering bug and simplify code in actions component. Remove duplicate separators and redundant fragments from menu items in packages/core-browser/src/components/actions/index.tsx.

@winjo winjo requested a review from Ricbet June 15, 2023 07:55
@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.98 🎉

Comparison is base (0e85c94) 52.69% compared to head (0467eec) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
+ Coverage   52.69%   57.67%   +4.98%     
==========================================
  Files        1336     1336              
  Lines       83883    83883              
  Branches    17439    17439              
==========================================
+ Hits        44201    48382    +4181     
+ Misses      36031    32266    -3765     
+ Partials     3651     3235     -416     
Flag Coverage Δ
jsdom 52.69% <ø> (+<0.01%) ⬆️
node 16.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@winjo winjo merged commit c2b224f into main Jun 15, 2023
15 checks passed
@winjo winjo deleted the fix/menu-key branch June 15, 2023 08:49
Ricbet pushed a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants