fix: add keys for fragment #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricbet
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
馃 Generated by Copilot at 7c2a739
hasSeparatorvariable instead of checking for consecutive separators (link, link)React.Fragmentcomponent with a unique key and conditionally render aMenu.Dividercomponent after each node ifhasSeparatoris true, to avoid duplicate keys and unnecessary dividers in theactions/index.tsxfile (link)Changelog
馃 Generated by Copilot at 7c2a739
Simplify and fix menu separators in
core-browserpackage. Use a variable and fragments to avoid duplicate or missing dividers between menu nodes inactions/index.tsx.