Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support search preference by @ext expression #2813

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 16, 2023

Types

  • 🎉 New Features

Background or solution

通过插件 ID 搜索配置

image

优化下划线样式
image

🤖 Generated by Copilot at ab47b24

  • Add support for filtering settings by extension ID (link, link, link, link, link, link)
  • Improve style of overwritten preference indicator (link)
  • Fix typo in comment of getPreferenceViewDesc (link)

Changelog

🤖 Generated by Copilot at ab47b24

This pull request adds the ability to filter settings by extension ID in the preferences UI. It introduces a new extensionId property to the ISettingSection interface and passes it from the extension configuration contributions to the PreferenceSettingsService class. It also improves the style of the overwritten preference indicator in the preferences.module.less file.

@erha19 erha19 requested a review from bytemain June 16, 2023 08:27
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (c2b224f) 57.67% compared to head (ab47b24) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   57.67%   57.67%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       83883    83894      +11     
  Branches    17439    17446       +7     
==========================================
+ Hits        48378    48382       +4     
- Misses      32270    32275       +5     
- Partials     3235     3237       +2     
Flag Coverage Δ
jsdom 52.69% <50.00%> (-0.01%) ⬇️
node 16.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/preferences/settings.ts 100.00% <ø> (ø)
...on/src/browser/vscode/contributes/configuration.ts 65.21% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 71.54% <50.00%> (-1.26%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain merged commit c606e24 into main Jun 26, 2023
15 checks passed
@bytemain bytemain deleted the feat/support-find-extension-preference branch June 26, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants