fix: unwatchFileChanges api do not work on file service #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miserylee 感谢贡献，这个修复可以修到 v2.25 分支上，跟随我们近期的 patch 版本，v2.25.2，具体需要从 v2.25 分支中切出分支重新提交一下相关代码修改 |
|
/backport to v2.25 |
|
Backporting to |
erha19
changed the title
erha19
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at ba9e64a
watchmethod of the provider to resolve the watcherId (link)watchFileChanges 时，调用 provider.watch 获取 watcherId，watch 方法返回值可能是 promise，这里如果不 await，会导致获取到的 watcherId 不是 number 类型，后面 provider.unwatch 会什么都不干，因此导致 unwatchFileChanges 不生效
Changelog
🤖 Generated by Copilot at ba9e64a
Await file watcher promises and register disposers correctly. This fixes a bug in
file-service.tsthat caused some file watchers to leak.