Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve render blank lines breakpoints #2832

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jun 27, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at ed951d4

  • Add a new CSS class blank to style blank breakpoints (link)
  • Extract a new function renderDescription to return a span element with the breakpoint description or a placeholder text (link)
  • Use renderDescription to render the breakpoint description in the BreakpointItem component (link)
  • Add a new localization key debug.breakpoint.blank and its values for English and Chinese languages (link, link)

image

Changelog

🤖 Generated by Copilot at ed951d4

This pull request improves the display of breakpoints in the debug view by adding a placeholder description for blank breakpoints and localizing the description text. It affects the files debug-breakpoints.view.tsx, debug-breakpoints.module.less, and the language files en-US.lang.ts and zh-CN.lang.ts.

@Ricbet Ricbet self-assigned this Jun 27, 2023
@opensumi opensumi bot added the 🎨 feature feature required label Jun 27, 2023
@Ricbet Ricbet linked an issue Jun 27, 2023 that may be closed by this pull request
@Ricbet Ricbet force-pushed the feat/improve-debug-blank-line branch from ed951d4 to 5c82d15 Compare June 28, 2023 07:59
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2eaedf2) 57.64% compared to head (5c82d15) 57.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2832   +/-   ##
=======================================
  Coverage   57.64%   57.65%           
=======================================
  Files        1336     1336           
  Lines       83949    83949           
  Branches    17456    17456           
=======================================
+ Hits        48395    48401    +6     
+ Misses      32317    32312    -5     
+ Partials     3237     3236    -1     
Flag Coverage Δ
jsdom 52.68% <ø> (+<0.01%) ⬆️
node 16.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit 519dec3 into main Jun 28, 2023
12 checks passed
@Ricbet Ricbet deleted the feat/improve-debug-blank-line branch June 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 优化断点面板对于空行的展示
2 participants