Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge editor not support wordwrap #2836

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jun 27, 2023

Types

  • ๐Ÿ› Bug Fixes

Background or solution

๐Ÿค– Generated by Copilot at cb3acd2

  • Import the IDiffEditorConstructionOptions type from @opensumi/monaco-editor-core to use a more accurate type for the mergedOptions variable in the createMergeEditor method (link)
  • Set the wordWrap option to 'off' in the mergedOptions variable to fix a bug that causes incorrect diff indicators in the merge editor (link)

merge editor ไธๆ”ฏๆŒ wordWrap ้…็ฝฎ

Changelog

๐Ÿค– Generated by Copilot at cb3acd2

This pull request enhances the merge editor feature of the editor collection service. It uses a more specific type for the editor options and disables word wrapping for better diff visibility.

@Ricbet Ricbet self-assigned this Jun 27, 2023
@opensumi opensumi bot added ๐Ÿž bug Something isn't working ๐ŸŽจ feature feature required labels Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 โš ๏ธ

Comparison is base (462c7c0) 57.66% compared to head (cb3acd2) 57.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   57.66%   57.66%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       83923    83923              
  Branches    17455    17455              
==========================================
- Hits        48398    48397       -1     
- Misses      32288    32290       +2     
+ Partials     3237     3236       -1     
Flag Coverage ฮ”
jsdom 52.68% <0.00%> (-0.01%) โฌ‡๏ธ
node 16.78% <0.00%> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
...es/editor/src/browser/editor-collection.service.ts 65.64% <0.00%> (รธ)

... and 2 files with indirect coverage changes

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain merged commit 1ca639f into main Jun 28, 2023
15 checks passed
@bytemain bytemain deleted the fix/merge-editor-wordwrap-off branch June 28, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿž bug Something isn't working ๐ŸŽจ feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants