Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editor tab support revealInExplorer #2848

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

pipiiiiii
Copy link
Contributor

@pipiiiiii pipiiiiii commented Jun 28, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 2652619

  • Add a menu item to reveal the current file in the explorer view (link)
  • Make the FILE_COMMANDS.REVEAL_IN_EXPLORER command accept either a URI or a resource object with a URI property (link)
  • Extract the URI from the resource object if needed in file-tree-contribution.ts (link)

ISSUE: #2845

Changelog

🤖 Generated by Copilot at 2652619

This pull request adds a new feature to reveal the current file in the explorer view from the editor title context menu, and improves the flexibility of the FILE_COMMANDS.REVEAL_IN_EXPLORER command by allowing different types of file URI inputs. The changes affect the files editor.contribution.ts and file-tree-contribution.ts.

@opensumi opensumi bot added the 🎨 feature feature required label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (056e778) 57.67% compared to head (2652619) 57.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   57.67%   57.66%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       83923    83923              
  Branches    17455    17455              
==========================================
- Hits        48402    48394       -8     
- Misses      32285    32292       +7     
- Partials     3236     3237       +1     
Flag Coverage Δ
jsdom 52.68% <ø> (-0.01%) ⬇️
node 16.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pipiiiiii pipiiiiii merged commit d288f3d into main Jun 28, 2023
15 checks passed
@pipiiiiii pipiiiiii deleted the feat/reveal-in-explor branch June 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants