chore: optimize split panel re-render #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaaaash
force-pushed
the
chore/optimize-split-panel-re-render
branch
from
f1edb85
to
29a8c28
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
- Coverage 57.66% 57.65% -0.02%
==========================================
Files 1336 1336
Lines 83923 83949 +26
Branches 17455 17456 +1
==========================================
+ Hits 48398 48402 +4
- Misses 32288 32311 +23
+ Partials 3237 3236 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bytemain
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at f1edb85
childListwithReact.useMemoto improve performance and avoid mutation (link)elementswith aReact.useMemohook that returns a nested array of JSX elements (link)elementsbefore rendering (link)Changelog
🤖 Generated by Copilot at f1edb85
This pull request improves the split panel component in
core-browserby using memoization and filtering techniques to avoid unnecessary re-rendering and handle edge cases. This makes the component faster, cleaner, and more reliable.