Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lint rules for ignore warning #2855

Merged
merged 1 commit into from
Jun 29, 2023
Merged

chore: add lint rules for ignore warning #2855

merged 1 commit into from
Jun 29, 2023

Conversation

pipiiiiii
Copy link
Contributor

@pipiiiiii pipiiiiii commented Jun 29, 2023

Types

  • 💄 Code Style Changes
  • 🧹 Chores

Background or solution

🤖 Generated by Copilot at 05f71c2

  • Disable @typescript-eslint/no-non-null-assertion rule in ESLint configuration (link)
  • Remove unused promise variable from OpenedEditorModelService class (link)
  • Move promise variable declaration to inner scope of loop in OpenedEditorModelService class (link)
  • Remove unused ILogger imports from opened-editor-model.service.test.ts file (link)
  • Add __mocks__ folder to .eslintignore file (link)

before:
image
after:
lint-after

Changelog

🤖 Generated by Copilot at 05f71c2

This pull request refactors and cleans up the code of the OpenedEditorModelService class and its related files. It also adjusts the ESLint configuration and ignores the mock files for testing.

@pipiiiiii pipiiiiii requested a review from Ricbet June 29, 2023 08:32
@opensumi opensumi bot added the ⚙️ refactor Refactor code label Jun 29, 2023
@pipiiiiii pipiiiiii requested a review from bk1012 June 29, 2023 08:33
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b67895d) 57.62% compared to head (05f71c2) 57.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files        1336     1336           
  Lines       83975    83975           
  Branches    17462    17462           
=======================================
  Hits        48390    48390           
  Misses      32342    32342           
  Partials     3243     3243           
Flag Coverage Δ
jsdom 52.65% <100.00%> (ø)
node 16.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/browser/services/opened-editor-model.service.ts 78.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pipiiiiii pipiiiiii merged commit 04c6527 into main Jun 29, 2023
15 checks passed
@pipiiiiii pipiiiiii deleted the chore/lint-ignore branch June 29, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants