Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: left panel style lower right menu style #2888

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: left panel style lower right menu style #2888

merged 1 commit into from
Jul 13, 2023

Conversation

wangxiaojuan
Copy link
Contributor

@wangxiaojuan wangxiaojuan commented Jul 13, 2023

Types

  • 🐛 Bug Fixes

fix: #2887

Background or solution

开发环境没发现是因为只有一个图标,在全局有个公共样式会影响到多个图标的情况
image

Changelog

fix: 修复左侧sidebar右下角图标偏移

@opensumi opensumi bot added 🐞 bug Something isn't working 💄 style change labels Jul 13, 2023
@wangxiaojuan wangxiaojuan requested a review from Ricbet July 13, 2023 04:36
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (290cf82) 57.62% compared to head (6ebf39d) 57.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   57.62%   57.61%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       84016    84016              
  Branches    17465    17465              
==========================================
- Hits        48415    48408       -7     
- Misses      32357    32363       +6     
- Partials     3244     3245       +1     
Flag Coverage Δ
jsdom 52.65% <ø> (-0.01%) ⬇️
node 16.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain merged commit 801236a into main Jul 13, 2023
14 checks passed
@bytemain bytemain deleted the fix/icon_style branch July 13, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 侧边栏设置界面图标偏移
3 participants