Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preference): rerender Select component if localized string changed #2892

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

#2880 的后续修复

Changelog

Preference Panel: rerender Select component if localized string changed

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 14, 2023
@bytemain
Copy link
Member Author

/backport to v2.24

@opensumi
Copy link
Contributor

opensumi bot commented Jul 14, 2023

Backporting to v2.24 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (606f46b) 57.63% compared to head (0a909d1) 57.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2892   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files        1337     1337           
  Lines       84116    84123    +7     
  Branches    17482    17482           
=======================================
+ Hits        48479    48486    +7     
- Misses      32387    32388    +1     
+ Partials     3250     3249    -1     
Flag Coverage Δ
jsdom 52.64% <62.50%> (-0.01%) ⬇️
node 16.80% <68.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erences/src/browser/preference-settings.service.ts 71.06% <60.00%> (-0.49%) ⬇️
packages/utils/src/event.ts 72.68% <100.00%> (+0.67%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain
Copy link
Member Author

/backport to v2.24

@opensumi
Copy link
Contributor

opensumi bot commented Jul 14, 2023

Backporting to v2.24 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

@bytemain
Copy link
Member Author

/backport to v2.24

@opensumi
Copy link
Contributor

opensumi bot commented Jul 14, 2023

Backporting to v2.24 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

@erha19 erha19 changed the base branch from v2.25 to main July 17, 2023 09:34
@bytemain bytemain force-pushed the fix/re-render-select-if-children-changed branch from 3c7c75c to b4def76 Compare July 18, 2023 02:01
@bytemain bytemain force-pushed the fix/re-render-select-if-children-changed branch from b4def76 to 4e9cf96 Compare July 18, 2023 02:03
@bytemain bytemain merged commit 1a9bedc into main Jul 18, 2023
12 checks passed
@bytemain bytemain deleted the fix/re-render-select-if-children-changed branch July 18, 2023 09:18
@bytemain
Copy link
Member Author

/backport to v2.24

@opensumi
Copy link
Contributor

opensumi bot commented Jul 20, 2023

Backporting to v2.24 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants