Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug console repl not show #2898

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: debug console repl not show #2898

merged 1 commit into from
Jul 17, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jul 17, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at e3bfecd

  • Prevent re-initializing input editor in DebugConsoleService by adding a guard clause (link)
  • Refactor DebugConsoleView component to use useRef hook instead of createRef hook for accessing DOM elements (link, link, link)
  • Move disposer variable inside useEffect hook to align with component lifecycle (link)

image

Changelog

🤖 Generated by Copilot at e3bfecd

This pull request improves the stability and performance of the DebugConsoleView component and the DebugConsoleService class in the packages/debug module. It fixes some issues with accessing and cleaning up DOM elements and editor instances.

@Ricbet Ricbet self-assigned this Jul 17, 2023
@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (72288f5) 57.62% compared to head (e3bfecd) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   57.62%   57.62%   -0.01%     
==========================================
  Files        1337     1337              
  Lines       84081    84083       +2     
  Branches    17475    17476       +1     
==========================================
- Hits        48454    48453       -1     
- Misses      32379    32382       +3     
  Partials     3248     3248              
Flag Coverage Δ
jsdom 52.66% <0.00%> (-0.01%) ⬇️
node 16.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/browser/view/console/debug-console.service.ts 15.27% <0.00%> (-0.16%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit 1b64c51 into main Jul 17, 2023
15 checks passed
@Ricbet Ricbet deleted the fix/debug-console-input branch July 17, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] debug.console.wordWrap 设置为 false 后,调试控制台的输入框不渲染
2 participants