Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title-bar add i18n tips (#2903) #2905

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: title-bar add i18n tips (#2903) #2905

merged 1 commit into from
Jul 18, 2023

Conversation

zhuzeyu22
Copy link
Contributor

@zhuzeyu22 zhuzeyu22 commented Jul 18, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at a53e3f3

  • Replace EllipsisWidget with Button component for more actions button in browser actions, and add title prop for tooltip (link, link)
  • Add moreTitle prop to EllipsisWidgetProps, ActionWidget, ActionGroup, and InlineMenuBarProps interfaces to allow custom tooltip text for more actions button (link, link, link, link)
  • Pass moreTitle prop to EllipsisWidget, ActionGroup, and InlineMenuBar components from their parent components, using localized text from i18n module (link, link, link)
  • Change localization text for scm.action.git.more key from '提交' to '更多操作...' in zh-CN.lang.ts file to match more actions button meaning (link)

Changelog

🤖 Generated by Copilot at a53e3f3

Improved the usability and consistency of the action buttons in the browser UI. Used Button components with tooltips instead of EllipsisWidget for clarity. Updated the localization text for the more actions button in the SCM view.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (606f46b) 57.63% compared to head (a53e3f3) 57.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files        1337     1337           
  Lines       84116    84116           
  Branches    17482    17482           
=======================================
  Hits        48479    48479           
  Misses      32387    32387           
  Partials     3250     3250           
Flag Coverage Δ
jsdom 52.64% <ø> (ø)
node 16.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 9ea0825 into opensumi:main Jul 18, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants