Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve file tree render speed #2912

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 20, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 81fc227

  • Simplify the code by removing unnecessary promises (link)

fixed opensumi/ide-startup#75.

Changelog

🤖 Generated by Copilot at 81fc227

This pull request improves the file tree component by simplifying the code and reducing the blocking of the UI. It removes unnecessary async and await keywords from file-tree.service.ts and moves the file change listener to a non-blocking position in file-tree-model.service.ts.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac1e2c7) 57.63% compared to head (81fc227) 57.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.26    #2912   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files        1337     1337           
  Lines       84130    84128    -2     
  Branches    17483    17483           
=======================================
+ Hits        48485    48491    +6     
+ Misses      32395    32388    -7     
+ Partials     3250     3249    -1     
Flag Coverage Δ
jsdom 52.65% <100.00%> (+<0.01%) ⬆️
node 16.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/file-tree-next/src/browser/file-tree.service.ts 70.25% <100.00%> (-0.16%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 55.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 4fc2ec7 into v2.26 Jul 20, 2023
15 checks passed
@erha19 erha19 deleted the fix/improve-file-tree-render-speed branch July 20, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants