Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add activate keybinding for explorer and search view #2930

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 24, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 1a01956

  • Add keybindings for activating the explorer and search views in the sidebar (link, link)
  • Remove redundant keybinding for revealing the current file in the explorer view (link)

image

为资源管理器和搜索面板添加激活快捷键,需要注意的是,cmd+shift+e 快捷键在 Chrome 默认情况下为保留快捷键,无法生效,需要搭配 https://github.com/opensumi/shortcuts-guard 使用(待适配)

Changelog

🤖 Generated by Copilot at 1a01956

This pull request adds or updates keybindings for activating the explorer and search views in the sidebar, following the conventions of VS Code and other IDEs. It also removes a redundant keybinding for revealing the current file in the explorer view.

@opensumi opensumi bot added the 🎨 feature feature required label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e7e61b) 57.63% compared to head (1a01956) 57.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2930   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files        1337     1337           
  Lines       84130    84130           
  Branches    17483    17483           
=======================================
  Hits        48485    48485           
  Misses      32395    32395           
  Partials     3250     3250           
Flag Coverage Δ
jsdom 52.64% <ø> (ø)
node 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit ea11d5e into main Jul 25, 2023
15 checks passed
@erha19 erha19 deleted the feat/add-view-keybinding branch July 25, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants