Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix select component style #2949

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Jul 26, 2023

Types

  • 🐛 Bug Fixes
  • 💄 Style Changes

Background or solution

#2929 样式修改导致了如下问题:
image

修复后:

CleanShot 2023-07-26 at 17 32 38@2x

Changelog

🤖 Generated by Copilot at 6443710

Improve select component option styling. Add a new class .kt-select-option-wrapper in style.less to adjust the option wrapper appearance.

fix select component style

@opensumi opensumi bot added 🐞 bug Something isn't working 💄 style change labels Jul 26, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Jul 26, 2023

ChatGPT Code Review:

修改建议:

  • 第7行代码应修改为.kt-select-option-wrapper > span
  • 第13行代码应修改为.kt-select-option-wrapper > span

代码功能描述:修复了选择组件的样式问题。根据提交的 diff,代码修改了选择选项的样式,包括调整了字体颜色、背景色和边距等。这些修改旨在解决一个已知的样式问题,以确保选择组件在界面上正确显示。

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (3e063a2) 57.63% compared to head (6443710) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.26    #2949      +/-   ##
==========================================
- Coverage   57.63%   57.62%   -0.01%     
==========================================
  Files        1337     1337              
  Lines       84145    84145              
  Branches    17487    17487              
==========================================
- Hits        48498    48491       -7     
- Misses      32398    32404       +6     
- Partials     3249     3250       +1     
Flag Coverage Δ
jsdom 52.63% <ø> (-0.01%) ⬇️
node 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 957d427 into v2.26 Jul 26, 2023
15 checks passed
@bytemain bytemain deleted the fix/styles/component-select branch July 26, 2023 11:41
@bytemain
Copy link
Member Author

#2942

close: #2942

bytemain added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants