Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change extension window.state default true #2951

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

pipiiiiii
Copy link
Contributor

@pipiiiiii pipiiiiii commented Jul 26, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 0f24add

  • Fix window focus and activation issues for extensions (link, F

关联 Issue: #2909

有一些插件会依赖这个状态,例如 git 插件:https://github.com/microsoft/vscode/blob/main/extensions/git/src/repository.ts#L2322

这里如果默认 false,会导致一些场景与实际状态不一致,比如:刷新浏览器、重启插件进程。会引起 SCM 面板更新不及时的情况。

Changelog

🤖 Generated by Copilot at 0f24add

Fix window focus and activation issues for extensions. Change the default value of focused to true in WindowStateImpl constructor.

@pipiiiiii pipiiiiii requested review from erha19 and Ricbet July 26, 2023 09:48
@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 26, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Jul 26, 2023

ChatGPT Code Review:

修改建议:

  • 将注释部分的文字进行修改,使其更加清晰和准确。
  • 在注释中提到的插件链接中,将"git"改为"VS Code Git 插件"。
  • 在代码中,将"false"改为"true"。

代码功能描述:该代码片段是关于修复一个 bug 的。在代码中,修改了一个变量的默认值,将其从"false"改为"true"。修改后的默认值更准确地与实际状态一致,修复了与其相关的插件处理问题。

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (3e063a2) 57.63% compared to head (0f24add) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.26    #2951      +/-   ##
==========================================
- Coverage   57.63%   57.62%   -0.01%     
==========================================
  Files        1337     1337              
  Lines       84145    84145              
  Branches    17487    17487              
==========================================
- Hits        48498    48492       -6     
- Misses      32398    32403       +5     
- Partials     3249     3250       +1     
Flag Coverage Δ
jsdom 52.63% <100.00%> (-0.01%) ⬇️
node 16.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ion/src/hosted/api/vscode/ext.host.window-state.ts 69.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit acd571b into v2.26 Jul 26, 2023
15 checks passed
@Ricbet Ricbet deleted the fix/scm-status-sync branch July 26, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants