Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support vscode workbench.action.openGlobalKeybindings commands #2970

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

pipiiiiii
Copy link
Contributor

@pipiiiiii pipiiiiii commented Aug 1, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 0b4871b

  • Add a new command to register VS Code built-in command for opening global keybindings file (link)
  • Define the new command as a constant and delegate it to the common command provided by the framework (link)

support command workbench.action.openGlobalKeybindings

Changelog

🤖 Generated by Copilot at 0b4871b

Added support for the VS Code built-in command settings.openGlobalKeybindings that opens the global keybindings file. Implemented the command by delegating to the existing COMMON_COMMANDS.OPEN_KEYMAPS command in the extension package.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 1, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Aug 1, 2023

ChatGPT Code Review:

建议修改:

  1. extension.contribution.ts 文件中,将 VSCodeBuiltinCommands.SETTINGS_COMMAND_OPEN_GLOBAL_OPEN_KEYMAPS 修改为 VSCodeBuiltinCommands.SETTINGS_COMMAND_OPEN_GLOBAL_KEYMAPS
  2. builtin-commands.ts 文件中,修改 SETTINGS_COMMAND_OPEN_GLOBAL_OPEN_KEYMAPSid'workbench.action.openGlobalKeybindings'

代码的功能是支持命令 workbench.action.openGlobalKeybindings,通过修改两个文件中的代码,将其添加到内置命令中。这将允许用户通过命令面板或键盘快捷键打开全局按键绑定。

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (2f9e770) 57.63% compared to head (0b4871b) 57.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.26    #2970      +/-   ##
==========================================
- Coverage   57.63%   57.63%   -0.01%     
==========================================
  Files        1337     1337              
  Lines       84182    84162      -20     
  Branches    17503    17491      -12     
==========================================
- Hits        48522    48505      -17     
+ Misses      32409    32406       -3     
  Partials     3251     3251              
Flag Coverage Δ
jsdom 52.64% <100.00%> (+<0.01%) ⬆️
node 16.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/extension/src/browser/vscode/builtin-commands.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 3a2cde3 into v2.26 Aug 2, 2023
15 checks passed
@erha19 erha19 deleted the fix/keymap-command branch August 2, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants