Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: diff editor type #2978

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: diff editor type #2978

merged 1 commit into from
Aug 7, 2023

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Aug 7, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 97a4835

  • Change the condition for applying non-code editor options to all editor types except CODE (link)

Changelog

🤖 Generated by Copilot at 97a4835

Fix non-code editor options for markdown and diff editors. Change the condition for applying non-code editor options in editor-collection.service.ts to exclude only CODE editors.

@opensumi
Copy link
Contributor

opensumi bot commented Aug 7, 2023

ChatGPT Code Review:

代码修改建议:

  • 将第一行的简介改为"fixed: diff editor type"
  • 在第一行简介的详细内容中删除所有不需要的选项,只保留"🐛 Bug Fixes"
  • 删除"copilot:walkthrough"和"copilot:summary"这两个注释
  • 修改第7行的代码,将"this.type > EditorType.CODE"改为"this.type !== EditorType.CODE"

代码功能:
此代码片段是对一个名为"BaseMonacoEditorWrapper"的抽象类中的"editor-collection.service.ts"文件进行修改的。修改的部分是在一个if语句中,原本是判断"this.type"是否大于"EditorType.CODE",现在修改为判断"this.type"是否不等于"EditorType.CODE"。这个if语句的作用是在特定条件下对"editorOptions"进行设置。其余部分没有进行修改。

@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (4c05b88) 57.63% compared to head (97a4835) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.26    #2978      +/-   ##
==========================================
- Coverage   57.63%   57.62%   -0.02%     
==========================================
  Files        1337     1337              
  Lines       84187    84166      -21     
  Branches    17504    17492      -12     
==========================================
- Hits        48523    48499      -24     
- Misses      32412    32414       +2     
- Partials     3252     3253       +1     
Flag Coverage Δ
jsdom 52.63% <100.00%> (-0.01%) ⬇️
node 16.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/editor/src/browser/editor-collection.service.ts 65.65% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 17a1bca into v2.26 Aug 7, 2023
17 checks passed
@bytemain bytemain deleted the fix/diff-editor-options branch August 7, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants