Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideOnDidAccept set default true #2981

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

pipiiiiii
Copy link
Contributor

@pipiiiiii pipiiiiii commented Aug 9, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 9ce2e9c

  • Add compatibility logic for hideOnDidAccept option of QuickInputService (link)

fix: #2944

Changelog

🤖 Generated by Copilot at 9ce2e9c

Refactor the QuickInputService class and add more features and options. Add compatibility logic for the hideOnDidAccept option in quick-input-service.ts.

@pipiiiiii pipiiiiii requested a review from Ricbet August 9, 2023 03:11
@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 9, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Aug 9, 2023

ChatGPT Code Review:

代码存在错误,错误拼写为"hideOnDidAccept"。

修改建议:
将拼写错误的"hideOnDidAccept"修改为正确拼写的"hidesOnDidAccept"。

代码的功能是在QuickInputService类中,对输入框的配置进行处理。在这段代码中,如果options中的"hideOnDidAccept"属性为undefined,则将其设置为true。这样就实现了兼容旧逻辑的功能。

@opensumi opensumi bot added the 🎨 feature feature required label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (63fa781) 57.63% compared to head (9ce2e9c) 57.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.26    #2981   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files        1337     1337           
  Lines       84165    84167    +2     
  Branches    17491    17492    +1     
=======================================
+ Hits        48506    48508    +2     
  Misses      32407    32407           
  Partials     3252     3252           
Flag Coverage Δ
jsdom 52.64% <100.00%> (+<0.01%) ⬆️
node 16.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ages/quick-open/src/browser/quick-input-service.ts 66.66% <100.00%> (+1.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 1f6d208 into v2.26 Aug 9, 2023
15 checks passed
@bytemain bytemain deleted the fix/quick-open-hide branch August 9, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants