Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve modifier keybinding ux #2999

Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix: improve modifier keybinding ux #2999

merged 2 commits into from
Aug 17, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Aug 17, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 6f745d4

  • Fix a bug where modifier key sequence was not cleared on non-modifier key press (link)

优化修饰符快捷键,如 shift+shift 在输入驼峰类型文本时的使用体验

Changelog

🤖 Generated by Copilot at 6f745d4

Fix a keybinding bug in core-browser that could trigger wrong commands. Clear the modifier key sequence when a non-modifier key is pressed in keybinding.ts.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 17, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Aug 17, 2023

ChatGPT Code Review:

代码审查结果:

  1. 第一处修改建议:
    将注释中的 "修饰符" 改为 "非修饰符"。
    修改后的注释为:"当传入的 KeyCode 不是非修饰符时,清空当前修饰符队列"

  2. 代码功能描述:
    该代码是在修饰符快捷键处理过程中的一个 bug 修复。修复的 bug 是在非修饰符按键按下时没有清空当前修饰符队列的问题。修改后的代码实现了当非修饰符按键按下时清空当前修饰符队列的功能。

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (17a1bca) 57.62% compared to head (e2e3f1d) 57.62%.
Report is 5 commits behind head on v2.26.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.26    #2999   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files        1337     1337           
  Lines       84166    84168    +2     
  Branches    17492    17492           
=======================================
+ Hits        48499    48505    +6     
+ Misses      32414    32410    -4     
  Partials     3253     3253           
Flag Coverage Δ
jsdom 52.63% <0.00%> (+<0.01%) ⬆️
node 16.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/core-browser/src/keybinding/keybinding.ts 73.91% <0.00%> (-0.21%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit ac91002 into v2.26 Aug 17, 2023
12 checks passed
@bytemain bytemain deleted the fix/modifier-keybinding branch August 17, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants