Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(component): remove select component unreasonable span selector" #3001

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

bytemain
Copy link
Member

Reverts #2929

@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 17, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Aug 17, 2023

ChatGPT Code Review:

代码审查结果:

  1. 在第103行,将className={classNames(className, 'kt-select-option-wrapper', { 'kt-option-disabled': disabled })}改为className={classNames(className, 'kt-select-option-wrapper', { 'kt-option-disabled': disabled })},因为现在的代码将kt-option-disabled作为对象传递给classNames,这可能造成类名在渲染时不正确,应该将其作为字符串传递。
  2. 在第130行和第150行,将span标签前的>符号移除,因为此处的span是父元素的直接子元素,不需要使用>符号指定子元素的选择器。
  3. yarn.lock文件中,将"word-wrap@npm:1.2.4"改为"word-wrap@npm:1.2.3",因为现在的代码使用了不可用的版本号。

代码功能描述:
此次更新是撤销了之前的修复,具体细节可以参考开源项目opensumi/core的#2929提交。这个diff主要是对packages/components/src/select/index.tsxpackages/components/src/select/style.less文件进行了修改。在index.tsx文件中,第103行的代码修改了Option组件的className属性,将kt-select-option-wrapperkt-option-disabled类名组合到了classNames函数中。在style.less文件中,第130行和第150行的代码对kt-select-option-select和其他选择器进行了一些样式调整。在yarn.lock文件中,修改了"word-wrap"模块的版本号从1.2.4改为1.2.3

@bytemain bytemain merged commit dac8675 into v2.26 Aug 17, 2023
12 checks passed
@bytemain bytemain deleted the revert-2929-fix/component/select-span branch August 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants