Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix left panel display #3021

Merged
merged 3 commits into from
Aug 29, 2023
Merged

fix: fix left panel display #3021

merged 3 commits into from
Aug 29, 2023

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

Fix left panel click not work

@bytemain bytemain changed the base branch from main to v2.26 August 28, 2023 08:06
@bytemain
Copy link
Member Author

/next

@opensumi opensumi bot added the 🐞 bug Something isn't working label Aug 28, 2023
@opensumi
Copy link
Contributor

opensumi bot commented Aug 28, 2023

🎉 PR Next version 2.26.7-next-1693210482.0 publish successful! You can install this version via npm install package@2.26.7-next-1693210482.0

2.26.7-next-1693210482.0

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (8d9987a) 57.67% compared to head (411421a) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.26    #3021      +/-   ##
==========================================
- Coverage   57.67%   57.62%   -0.05%     
==========================================
  Files        1337     1339       +2     
  Lines       84486    84290     -196     
  Branches    17591    17518      -73     
==========================================
- Hits        48727    48575     -152     
+ Misses      32488    32459      -29     
+ Partials     3271     3256      -15     
Flag Coverage Δ
jsdom 52.64% <100.00%> (-0.05%) ⬇️
node 16.78% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/main-layout/src/common/main-layout.definition.ts 100.00% <ø> (ø)
...-layout/src/browser/accordion/accordion.service.ts 64.74% <100.00%> (+6.38%) ⬆️
packages/main-layout/src/browser/layout.service.ts 61.88% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试可用

@bytemain bytemain merged commit f9580b4 into v2.26 Aug 29, 2023
15 checks passed
@bytemain bytemain deleted the fix/tabbar/panel branch August 29, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants