feat: terminal split screen operation supports single deletion #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChatGPT Code Review:
代码的功能是在终端分屏组件中添加了一个可以单个面板删除的功能。具体实现为在每个面板后添加了一个关闭图标，点击该图标可以删除对应的面板。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 823 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
我感觉直接展示太多余了，可不可以做成用户鼠标移动到当前 terminal 上的时候，再显示这个 X |
erha19
requested changes
Sep 26, 2023
erha19
requested changes
Oct 12, 2023
packages/terminal-next/src/browser/component/resize.module.less
Outdated
Show resolved
Hide resolved
erha19
previously requested changes
Oct 16, 2023
bytemain
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
feat: #3042
Background or solution
Changelog
feat: 终端分屏时支持单个面板删除
🤖 Generated by Copilot at 0e22038
The pull request enhances the terminal tab functionality by adding a close button and improving the style. It also refactors some code to use core browser utilities and hooks in
resize.view.tsxandresize.module.less.