Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register sumi api in worker #3072

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

AhkunTa
Copy link
Member

@AhkunTa AhkunTa commented Sep 19, 2023

Types

  • ๐Ÿ› Bug Fixes

Background or solution

๐Ÿค– Generated by Copilot at 100d2f5

  • Import and register the Sumi API factory for the worker process service (link, link)
  • Refactor the apiFactoryDisposable property and the disposeApiFactory method to handle multiple API factories (link)
  • ไฟฎๅคworkerๅ†…่ฐƒ็”จ toolbar ่ดก็Œฎ็‚นๆŠฅ้”™
ๆˆชๅฑ2023-09-19 14 56 08

Changelog

๐Ÿค– Generated by Copilot at 100d2f5

This pull request enables extensions to use the Sumi API in the worker process. It modifies the extension-worker.service.ts file to integrate the Sumi API factory with the RPC and the injector.

@opensumi opensumi bot added the ๐Ÿž bug Something isn't working label Sep 19, 2023
@AhkunTa
Copy link
Member Author

AhkunTa commented Sep 19, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Sep 19, 2023

๐ŸŽ‰ PR Next version 2.26.9-next-1695107249.0 publish successful! You can install this version via npm install package@2.26.9-next-1695107249.0

2.26.9-next-1695107249.0

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 50.00% of modified lines.

Files Changed Coverage
.../extension/src/browser/extension-worker.service.ts 50.00%

๐Ÿ“ข Thoughts on this report? Let us know!.

@AhkunTa AhkunTa changed the title WIP fix: register sumi api in worker fix: register sumi api in worker Sep 21, 2023
@AhkunTa AhkunTa changed the base branch from v2.26 to main October 10, 2023 10:20
@bytemain bytemain merged commit bf1bfd3 into main Oct 10, 2023
18 checks passed
@bytemain bytemain deleted the fix/worker-host-MainThreadCommon-error branch October 10, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿž bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants