Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve preference checkbox style #3148

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 1, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at b05a2f9

  • Remove global style for .kt-checkbox and add margin-left to .desc to fix checkbox alignment in preferences panel (link)

问题样式:
image

这里移除了对于公共组件的强行覆盖,采用了局部样式进行控制

Changelog

🤖 Generated by Copilot at b05a2f9

Removed a global style that affected checkboxes and adjusted the margin of labels in preferences.module.less. This improves the appearance of the preferences panel.

@erha19 erha19 requested a review from bytemain November 1, 2023 07:06
@opensumi opensumi bot added 💄 style change 🐞 bug Something isn't working labels Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 9 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@erha19
Copy link
Member Author

erha19 commented Nov 1, 2023

close #2964.

@erha19 erha19 merged commit 71ed2ba into v2.27 Nov 1, 2023
15 checks passed
@erha19 erha19 deleted the style/preference-item-style branch November 1, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants