Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve panel section description style #3166

Merged
merged 12 commits into from
Nov 20, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 15, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at 60dcda4

  • Prevent accordion header from shrinking and improve layout (link)

这里的 flex 定义会导致空格失效,同时省略号样式失效

After:
截屏2023-11-15 10 36 12

Changelog

🤖 Generated by Copilot at 60dcda4

Improved the accordion header style to avoid shrinking and fill the space. Modified the flex properties in styles.module.less.

@opensumi opensumi bot added 🐞 bug Something isn't working 💄 style change labels Nov 15, 2023
@erha19 erha19 force-pushed the style/improve-panel-section-description-style branch from 7aff3a2 to 82639d6 Compare November 16, 2023 02:10
@erha19 erha19 force-pushed the style/improve-panel-section-description-style branch from 82639d6 to c5e37c3 Compare November 16, 2023 02:33
@erha19 erha19 force-pushed the style/improve-panel-section-description-style branch from 3a4933c to c7fac23 Compare November 16, 2023 03:04
@erha19 erha19 force-pushed the style/improve-panel-section-description-style branch from ebaffda to 92d6bc8 Compare November 16, 2023 03:48
@erha19 erha19 force-pushed the style/improve-panel-section-description-style branch from c329493 to ddf87a0 Compare November 16, 2023 07:34
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (070b671) 16.87% compared to head (ddf87a0) 57.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3166       +/-   ##
===========================================
+ Coverage   16.87%   57.69%   +40.81%     
===========================================
  Files        1340     1340               
  Lines       84533    84533               
  Branches    17583    17583               
===========================================
+ Hits        14266    48770    +34504     
+ Misses      64211    32502    -31709     
+ Partials     6056     3261     -2795     
Flag Coverage Δ
jsdom 52.60% <ø> (?)
node 16.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 2ee98e5 into main Nov 20, 2023
12 checks passed
@erha19 erha19 deleted the style/improve-panel-section-description-style branch November 20, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants