Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support DirectDebugAdapter debug type #3216

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 27, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖[deprecated] Generated by Copilot at dca5a22

  • Handle the case where debug tasks may not send the initialized request by setting the initialized property to true in the DebugSession class (link)
  • Import the Emitter class from the @opensumi/ide-core-common package to create events for the DirectDebugAdapter class (link)
  • Implement the DebugStreamConnection interface in the DirectDebugAdapter class, which requires the onClose, onMessageReceived, onError, start, and stop properties and methods (link)
  • Remove the unused parameters of the start method of the DirectDebugAdapter class, which are channel and outStream (link)

close #3158.

Changelog

🤖[deprecated] Generated by Copilot at dca5a22

This pull request refactors the debug adapter communication and fixes a bug in the debug session initialization. It introduces the DebugStreamConnection interface to standardize the communication between the debug adapter and the debug session, and removes unused parameters from the DirectDebugAdapter class. It also adds a line of code and a comment to handle the case where the debug adapter does not send the initialized request. The affected files are abstract-debug-adapter-session.ts, debug-session.ts, and extension-debug-adapter-starter.ts.

@opensumi opensumi bot added 🐞 bug Something isn't working ⚙️ refactor Refactor code labels Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (28aa219) 57.68% compared to head (dca5a22) 57.67%.

Files Patch % Lines
...api/vscode/debug/abstract-debug-adapter-session.ts 8.33% 11 Missing ⚠️
...pi/vscode/debug/extension-debug-adapter-starter.ts 0.00% 2 Missing ⚠️
packages/debug/src/browser/debug-session.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
- Coverage   57.68%   57.67%   -0.01%     
==========================================
  Files        1340     1340              
  Lines       84535    84543       +8     
  Branches    17583    17583              
==========================================
- Hits        48763    48762       -1     
- Misses      32512    32521       +9     
  Partials     3260     3260              
Flag Coverage Δ
jsdom 52.59% <6.66%> (-0.01%) ⬇️
node 16.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member Author

erha19 commented Nov 27, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Nov 27, 2023

🎉 PR Next version 2.27.2-next-1701084305.0 publish successful! You can install this version via npm install package@2.27.2-next-1701084305.0

2.27.2-next-1701084305.0

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit bec0669 into main Nov 28, 2023
16 checks passed
@erha19 erha19 deleted the feat/support-ios-debug branch November 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 希望支持VSCode插件以支持DX IDE的后续功能
2 participants