Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade monaco version 0.45.0 #3257

Merged
merged 26 commits into from
Mar 12, 2024
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jan 3, 2024

Types

  • 🎉 New Features

Background or solution

升级 monaco

Changelog

Upgrade monaco version to 0.45.0

@Ricbet Ricbet self-assigned this Jan 3, 2024
@Ricbet Ricbet force-pushed the chore/upgrade-monaco-version branch 2 times, most recently from 14e8c06 to bf7581a Compare January 12, 2024 07:13
@Ricbet Ricbet force-pushed the chore/upgrade-monaco-version branch from 0302569 to 839a9d6 Compare March 5, 2024 08:12
@Ricbet Ricbet changed the title WIP: chore: upgrade monaco version 0.45.0 chore: upgrade monaco version 0.45.0 Mar 5, 2024
@Ricbet
Copy link
Member Author

Ricbet commented Mar 5, 2024

相关变动见:#3213

Aaaaash
Aaaaash previously approved these changes Mar 5, 2024
packages/components/src/style/base.less Outdated Show resolved Hide resolved
@Ricbet Ricbet force-pushed the chore/upgrade-monaco-version branch from aaf88d7 to 10a9411 Compare March 8, 2024 03:46
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 62.24490% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 58.02%. Comparing base (f9865d0) to head (c97243c).

Files Patch % Lines
...s/monaco/src/browser/monaco.resolved-keybinding.ts 0.00% 17 Missing ⚠️
...s/monaco/src/browser/monaco.context-key.service.ts 0.00% 4 Missing ⚠️
...ackages/core-browser/src/services/label-service.ts 66.66% 2 Missing and 1 partial ⚠️
...ackages/editor/src/browser/preference/converter.ts 60.00% 2 Missing ⚠️
...es/workspace-edit/src/browser/bulk-edit.service.ts 0.00% 2 Missing ⚠️
...es/core-browser/src/ai-native/ai-config.service.ts 0.00% 1 Missing ⚠️
packages/debug/src/browser/debugUtils.ts 0.00% 1 Missing ⚠️
.../src/browser/view/console/debug-console.service.ts 0.00% 1 Missing ⚠️
...es/editor/src/browser/editor-collection.service.ts 50.00% 1 Missing ⚠️
...ion/src/browser/vscode/api/main.thread.language.ts 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
- Coverage   58.07%   58.02%   -0.05%     
==========================================
  Files        1413     1413              
  Lines       86804    86818      +14     
  Branches    17917    17920       +3     
==========================================
- Hits        50408    50375      -33     
- Misses      33108    33153      +45     
- Partials     3288     3290       +2     
Flag Coverage Δ
jsdom 53.17% <62.24%> (+0.23%) ⬆️
node 16.25% <3.06%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bytemain
bytemain previously approved these changes Mar 8, 2024
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit e183880 into main Mar 12, 2024
11 checks passed
@Ricbet Ricbet deleted the chore/upgrade-monaco-version branch March 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants