Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade mobx to v6 #3258

Merged
merged 29 commits into from
Jan 31, 2024
Merged

refactor: upgrade mobx to v6 #3258

merged 29 commits into from
Jan 31, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 3, 2024

Types

  • 🪚 Refactors

Background or solution

close #3254

Changelog

  • upgrade mobx5 to mobx6
  • upgrade react 18.0.0 to 18.2.0

@opensumi opensumi bot added the ⚙️ refactor Refactor code label Jan 3, 2024
@bytemain
Copy link
Member

bytemain commented Jan 3, 2024

要不 移除掉?

@erha19
Copy link
Member Author

erha19 commented Jan 3, 2024

要不 移除掉?

可以,我尝试一下

@bytemain
Copy link
Member

bytemain commented Jan 3, 2024

可以分配一点任务量给我

@erha19
Copy link
Member Author

erha19 commented Jan 3, 2024

@bytemain 你要不尝试一下移除 mainlayout 那层的 mobx 逻辑?关键代码在 packages/main-layout/src/browser/tabbar/tabbar.service.ts 这个文件,有三个 observable 值

@erha19
Copy link
Member Author

erha19 commented Jan 3, 2024

顺带解决 #2434 问题。

@bytemain
Copy link
Member

这个移除逻辑真的没有想象中的简单

@erha19
Copy link
Member Author

erha19 commented Jan 23, 2024

这个移除逻辑真的没有想象中的简单

@bytemain 先升级到 mobx6 吧,我基本完成了,后面找着删

@bytemain
Copy link
Member

要移除 mobx 的话,我们需要另一个 state 管理框架,能帮我们做一些自动 computed/自动 didChange 的工作

或者自己糊一个

@erha19 erha19 changed the title WIP: refactor: upgrade mobx to v6 refactor: upgrade mobx to v6 Jan 23, 2024
@erha19 erha19 requested review from Aaaaash, bytemain, AhkunTa and Ricbet and removed request for Aaaaash, bytemain and AhkunTa January 23, 2024 10:10
@erha19 erha19 changed the title refactor: upgrade mobx to v6 WIP: refactor: upgrade mobx to v6 Jan 24, 2024
@erha19 erha19 changed the title WIP: refactor: upgrade mobx to v6 refactor: upgrade mobx to v6 Jan 26, 2024
@erha19
Copy link
Member Author

erha19 commented Jan 27, 2024

@bytemain 顺便修了几个少升级的 mini-css-extract-plugin 版本

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (ffba86a) 57.75% compared to head (bf0e693) 57.80%.

Files Patch % Lines
...s/main-layout/src/browser/tabbar/tabbar.service.ts 60.00% 27 Missing and 1 partial ⚠️
...nsion-manager/src/browser/vsx-extension.service.ts 0.00% 10 Missing ⚠️
packages/main-layout/src/browser/layout.service.ts 42.85% 7 Missing and 1 partial ⚠️
...-layout/src/browser/accordion/accordion.service.ts 83.33% 4 Missing ⚠️
packages/overlay/src/browser/dialog.service.ts 25.00% 3 Missing ⚠️
...kages/terminal-next/src/browser/terminal.search.ts 0.00% 3 Missing ⚠️
...ckages/terminal-next/src/browser/terminal.error.ts 0.00% 2 Missing ⚠️
...onents/scm-resource-tree/scm-tree-model.service.ts 50.00% 1 Missing ⚠️
...kages/terminal-next/src/browser/terminal.client.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
+ Coverage   57.75%   57.80%   +0.04%     
==========================================
  Files        1357     1357              
  Lines       85020    85115      +95     
  Branches    17646    17642       -4     
==========================================
+ Hits        49103    49198      +95     
- Misses      32644    32646       +2     
+ Partials     3273     3271       -2     
Flag Coverage Δ
jsdom 52.68% <72.60%> (+0.05%) ⬆️
node 17.14% <4.10%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tools/dev-tool/src/webpack.js Outdated Show resolved Hide resolved
packages/core-browser/src/bootstrap/app.view.tsx Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Ricbet
Ricbet previously approved these changes Jan 30, 2024
packages/core-browser/package.json Outdated Show resolved Hide resolved
packages/main-layout/src/browser/tabbar/tabbar.service.ts Outdated Show resolved Hide resolved
packages/core-browser/package.json Outdated Show resolved Hide resolved
@bytemain bytemain merged commit 922ed90 into main Jan 31, 2024
12 checks passed
@bytemain bytemain deleted the refactor/upgrade-mobx-6 branch January 31, 2024 05:07
@erha19 erha19 added the v3 OpenSumi 3.0 label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] View 视图切换发送事件过多
3 participants