-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade mobx to v6 #3258
Conversation
要不 移除掉? |
可以,我尝试一下 |
可以分配一点任务量给我 |
@bytemain 你要不尝试一下移除 mainlayout 那层的 mobx 逻辑?关键代码在 packages/main-layout/src/browser/tabbar/tabbar.service.ts 这个文件,有三个 observable 值 |
顺带解决 #2434 问题。 |
f4e9984
to
194e701
Compare
这个移除逻辑真的没有想象中的简单 |
@bytemain 先升级到 mobx6 吧,我基本完成了,后面找着删 |
要移除 mobx 的话,我们需要另一个 state 管理框架,能帮我们做一些自动 computed/自动 didChange 的工作 或者自己糊一个 |
db58f70
to
9b6b92e
Compare
@bytemain 顺便修了几个少升级的 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
+ Coverage 57.75% 57.80% +0.04%
==========================================
Files 1357 1357
Lines 85020 85115 +95
Branches 17646 17642 -4
==========================================
+ Hits 49103 49198 +95
- Misses 32644 32646 +2
+ Partials 3273 3271 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
07e2d5e
to
9adda22
Compare
Types
Background or solution
close #3254
Changelog