Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): avoid incorrect dispose of connection #3266

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

in the electron version, if some secrity software connect our ipc socket and then leave, the server will dispose all service, this is an wrong behaviour.

Changelog

[electron] avoid incorrect dispose of connection

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jan 10, 2024
@bytemain bytemain changed the title fix: avoid incorrect dispose of connection fix(electron): avoid incorrect dispose of connection Jan 10, 2024
@MMhunter
Copy link
Contributor

LGTM

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (31c1064) 57.64% compared to head (acb3c7b) 57.61%.
Report is 6 commits behind head on v2.27.

Files Patch % Lines
...s/terminal-next/src/browser/terminal.controller.ts 40.00% 3 Missing ⚠️
packages/core-node/src/connection.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v2.27    #3266      +/-   ##
==========================================
- Coverage   57.64%   57.61%   -0.04%     
==========================================
  Files        1339     1339              
  Lines       84380    84379       -1     
  Branches    17545    17545              
==========================================
- Hits        48641    48611      -30     
- Misses      32479    32505      +26     
- Partials     3260     3263       +3     
Flag Coverage Δ
jsdom 52.66% <28.57%> (-0.01%) ⬇️
node 16.73% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit acc9e62 into v2.27 Jan 11, 2024
12 checks passed
@bytemain bytemain deleted the fix/avoid-connection-dispose branch January 11, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants