Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unified connection with different backend #3348

Merged
merged 10 commits into from
Feb 21, 2024
Merged

feat: unified connection with different backend #3348

merged 10 commits into from
Feb 21, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

this close: #1270

previous we use wschannel to communicate with backend in Web, in electron, we create a new socket.

here we unified web and electron, all of those are using WSChannel

Changelog

@bytemain bytemain changed the title feat: unified connection with different backend @bytemain feat: unified connection with different backend Feb 20, 2024
Copy link

railway-app bot commented Feb 20, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🎨 feature feature required label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 117 lines in your changes are missing coverage. Please review.

Comparison is base (f243e35) 58.06% compared to head (a419169) 58.08%.

Files Patch % Lines
...connection/src/common/connection/drivers/stream.ts 0.00% 37 Missing and 4 partials ⚠️
packages/connection/src/common/server-handler.ts 76.41% 23 Missing and 2 partials ⚠️
packages/extension/src/node/extension.service.ts 0.00% 19 Missing and 2 partials ⚠️
packages/core-browser/src/bootstrap/app.ts 21.05% 15 Missing ⚠️
packages/core-node/src/connection.ts 37.50% 8 Missing and 2 partials ⚠️
...ages/connection/src/node/common-channel-handler.ts 77.77% 2 Missing ⚠️
...es/extension/src/browser/extension-node.service.ts 33.33% 2 Missing ⚠️
...ackages/connection/src/electron/channel-handler.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   58.06%   58.08%   +0.02%     
==========================================
  Files        1372     1376       +4     
  Lines       85764    85814      +50     
  Branches    17744    17753       +9     
==========================================
+ Hits        49798    49845      +47     
- Misses      32704    32706       +2     
- Partials     3262     3263       +1     
Flag Coverage Δ
jsdom 52.88% <31.57%> (+0.02%) ⬆️
node 17.77% <48.98%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 16a4b1b into main Feb 21, 2024
12 checks passed
@bytemain bytemain deleted the feat/handler branch February 21, 2024 06:59
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 统一 Electron / Web 连接层,建立更简单的前后端通信模式
3 participants