Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement design module #3350

Merged
merged 27 commits into from
Feb 29, 2024
Merged

feat: implement design module #3350

merged 27 commits into from
Feb 29, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Feb 20, 2024

Types

  • 🎉 New Features
  • 💄 Style Changes

Background or solution

  • 实现 OpenSumi Design 模块
  • 内置两款默认主题,design dark 和 design light,不需要安装插件

使用方式
直接引入 DesignModule 即可
image

内置两款 design 主题可以选择
image

整体预览效果

dark
image

light
image

也支持其他非 design 主题
image

Changelog

@Ricbet Ricbet added the v3 OpenSumi 3.0 label Feb 20, 2024
@Ricbet Ricbet self-assigned this Feb 20, 2024
Copy link

railway-app bot commented Feb 20, 2024

This PR was not deployed automatically as @Ricbet does not have access to the Railway project.

In order to get automatic PR deploys, please add @Ricbet to the project inside the project settings page.

@opensumi opensumi bot added the 🎨 feature feature required label Feb 20, 2024
@Ricbet Ricbet force-pushed the feat/support-sumi-design branch 2 times, most recently from a0f53c2 to ebb048e Compare February 21, 2024 12:46
@bytemain
Copy link
Member

好像你的 import {} 里的 order 被调了一遍,可以先把这个变更提个 pr

@Ricbet
Copy link
Member Author

Ricbet commented Feb 22, 2024

好像你的 import {} 里的 order 被调了一遍,可以先把这个变更提个 pr

关联 PR:#3357

@Ricbet Ricbet changed the title WIP: feat: implement design module feat: implement design module Feb 23, 2024
@Ricbet Ricbet changed the title feat: implement design module WIP:feat: implement design module Feb 26, 2024
@Ricbet Ricbet changed the title WIP:feat: implement design module feat: implement design module Feb 27, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 56.34518% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 58.04%. Comparing base (deba510) to head (d85b749).

Files Patch % Lines
packages/design/src/browser/index.ts 0.00% 39 Missing ⚠️
...s/design/src/browser/theme/file-system.provider.ts 0.00% 28 Missing and 1 partial ⚠️
...es/core-browser/src/design/design.style.service.ts 41.17% 8 Missing and 2 partials ⚠️
packages/editor/src/browser/editor.tab.service.ts 42.85% 4 Missing ⚠️
packages/core-browser/src/utils/react-hooks.ts 87.50% 1 Missing ⚠️
packages/design/src/browser/theme/default-theme.ts 0.00% 1 Missing ⚠️
packages/design/src/browser/theme/light-theme.ts 0.00% 1 Missing ⚠️
packages/extension/src/common/vscode/converter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   58.05%   58.04%   -0.02%     
==========================================
  Files        1376     1385       +9     
  Lines       85759    85914     +155     
  Branches    17754    17761       +7     
==========================================
+ Hits        49790    49867      +77     
- Misses      32706    32782      +76     
- Partials     3263     3265       +2     
Flag Coverage Δ
jsdom 52.85% <56.34%> (-0.01%) ⬇️
node 17.78% <29.94%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/components/src/icon/iconfont/iconMap.ts Outdated Show resolved Hide resolved
packages/components/src/icon/iconfont/iconMap.ts Outdated Show resolved Hide resolved
packages/components/src/icon/iconfont/iconMap.ts Outdated Show resolved Hide resolved
.yarnrc.yml Outdated Show resolved Hide resolved
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 611d1e5 into main Feb 29, 2024
11 checks passed
@bytemain bytemain deleted the feat/support-sumi-design branch February 29, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants