Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove implicit renderer runtime check #3360

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

previously, we use isElectronRenderer in everywhere to determine current runtime is Electron, here we remove the check function, we should only use the AppConfig.isElectronRenderer

Changelog

remove implicit renderer runtime check

@opensumi opensumi bot added the 🎨 feature feature required label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 69.32515% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (deba510) to head (52c07ef).

Files Patch % Lines
packages/core-browser/src/bootstrap/app.ts 60.46% 17 Missing ⚠️
...-browser/src/application/runtime/browser/socket.ts 35.71% 9 Missing ⚠️
packages/core-browser/src/bootstrap/connection.ts 25.00% 9 Missing ⚠️
...src/application/runtime/electron-renderer/index.ts 81.81% 4 Missing ⚠️
...rc/application/runtime/electron-renderer/socket.ts 50.00% 4 Missing ⚠️
...lectron-basic/src/browser/header/header.service.ts 84.61% 2 Missing ⚠️
...ebug/extension-debug-adapter-excutable-resolver.ts 33.33% 2 Missing ⚠️
...ckages/extension/src/hosted/worker.host-preload.ts 0.00% 2 Missing ⚠️
packages/extension/src/node/extension.service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
+ Coverage   58.05%   58.07%   +0.02%     
==========================================
  Files        1376     1383       +7     
  Lines       85759    85796      +37     
  Branches    17754    17745       -9     
==========================================
+ Hits        49790    49829      +39     
- Misses      32706    32708       +2     
+ Partials     3263     3259       -4     
Flag Coverage Δ
jsdom 52.87% <61.96%> (+0.01%) ⬆️
node 17.78% <48.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 2736596 into main Feb 29, 2024
11 checks passed
@bytemain bytemain deleted the feat/clean-architecture-1 branch February 29, 2024 03:57
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants