-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove implicit renderer runtime check #3360
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
+ Coverage 58.05% 58.07% +0.02%
==========================================
Files 1376 1383 +7
Lines 85759 85796 +37
Branches 17754 17745 -9
==========================================
+ Hits 49790 49829 +39
- Misses 32706 32708 +2
+ Partials 3263 3259 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
previously, we use
isElectronRenderer
in everywhere to determine current runtime isElectron
, here we remove the check function, we should only use theAppConfig.isElectronRenderer
Changelog
remove implicit renderer runtime check