-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sumi rpc support read stream #3362
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3362 +/- ##
==========================================
+ Coverage 58.09% 58.16% +0.07%
==========================================
Files 1406 1405 -1
Lines 86576 86676 +100
Branches 17866 17907 +41
==========================================
+ Hits 50298 50419 +121
+ Misses 32996 32974 -22
- Partials 3282 3283 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is being deployed to Railway 🚅 core: ◻️ REMOVED |
0b57dec
to
7b0626f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
previously, we just read full content of a file, if the file is so large, it will consume many memories, so our program maybe oom.
I took a look at the applicable scenarios that can be changed:
Changelog
sumi rpc support read stream