Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove mobx from preference panel #3366

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

bytemain
Copy link
Member

Types

  • 🪚 Refactors

Background or solution

just a try

Changelog

remove mobx from preference panel

@opensumi opensumi bot added the ⚙️ refactor Refactor code label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 45.23810% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 58.04%. Comparing base (deba510) to head (85cfa15).

Files Patch % Lines
...erences/src/browser/preference-settings.service.ts 45.23% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   58.05%   58.04%   -0.02%     
==========================================
  Files        1376     1376              
  Lines       85759    85769      +10     
  Branches    17754    17756       +2     
==========================================
- Hits        49790    49785       -5     
- Misses      32706    32721      +15     
  Partials     3263     3263              
Flag Coverage Δ
jsdom 52.84% <45.23%> (-0.02%) ⬇️
node 17.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erha19
erha19 previously approved these changes Feb 28, 2024
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 5e72abc into main Feb 29, 2024
11 checks passed
@bytemain bytemain deleted the refactor/remove-mobx-1 branch February 29, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants