Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment thread update #3369

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: comment thread update #3369

merged 1 commit into from
Feb 29, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Feb 29, 2024

Types

  • 🐛 Bug Fixes

Background or solution

修改原有代码中不合理的 thread.commands = [...] 更新视图的方式,后续需通过如下方式更新评论列表

thread.updateComments([...]); // 包裹了 @action 方法

Changelog

fix comment thread update logic

@opensumi opensumi bot added the 🐞 bug Something isn't working label Feb 29, 2024
@erha19
Copy link
Member Author

erha19 commented Feb 29, 2024

/next

@erha19 erha19 requested review from hacke2 and Ricbet February 29, 2024 03:17
@opensumi
Copy link
Contributor

opensumi bot commented Feb 29, 2024

🎉 PR Next version 2.27.3-next-1709176858.0 publish successful! You can install this version via npm install package@2.27.3-next-1709176858.0

2.27.3-next-1709176858.0

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.06%. Comparing base (deba510) to head (42ba115).

Files Patch % Lines
...ion/src/browser/vscode/api/main.thread.comments.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3369   +/-   ##
=======================================
  Coverage   58.05%   58.06%           
=======================================
  Files        1376     1376           
  Lines       85759    85763    +4     
  Branches    17754    17754           
=======================================
+ Hits        49790    49794    +4     
  Misses      32706    32706           
  Partials     3263     3263           
Flag Coverage Δ
jsdom 52.86% <87.50%> (+<0.01%) ⬆️
node 17.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 3eaa25c into main Feb 29, 2024
13 checks passed
@erha19 erha19 deleted the fix/comment-thread-update branch February 29, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants