Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uri should support serialize to json #3385

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Mar 7, 2024

Types

  • 🐛 Bug Fixes

Background or solution

when gitlens open diff editor, an error will shown:
image

the error directly caused by SumiConnection, but the deep reason is that URI didn't support serialization

Copy link

railway-app bot commented Mar 7, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 7, 2024
@bytemain bytemain changed the title fix: uri should support to json fix: uri should support serialize to json Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.07%. Comparing base (e2086b9) to head (1954a59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
- Coverage   58.07%   58.07%   -0.01%     
==========================================
  Files        1413     1413              
  Lines       86797    86805       +8     
  Branches    17916    17917       +1     
==========================================
  Hits        50409    50409              
- Misses      33101    33108       +7     
- Partials     3287     3288       +1     
Flag Coverage Δ
jsdom 52.93% <100.00%> (-0.01%) ⬇️
node 17.84% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member

erha19 commented Mar 7, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Mar 7, 2024

🎉 PR Next version 2.27.3-next-1709814700.0 publish successful! You can install this version via npm install package@2.27.3-next-1709814700.0

2.27.3-next-1709814700.0

@erha19
Copy link
Member

erha19 commented Mar 7, 2024

发现了一个新的问题,这个 PR 应该没啥问题,先合了

@erha19 erha19 merged commit 9f157f7 into main Mar 7, 2024
15 checks passed
@erha19 erha19 deleted the fix/error-shown-when-open-diff branch March 7, 2024 12:45
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants